Skip to content

fix: update digest lookup to use versioned RepoTags instead of latest#1935

Open
shivakunv wants to merge 1 commit intomainfrom
grouptagcommitwithbundle
Open

fix: update digest lookup to use versioned RepoTags instead of latest#1935
shivakunv wants to merge 1 commit intomainfrom
grouptagcommitwithbundle

Conversation

@shivakunv
Copy link
Contributor

@shivakunv shivakunv commented Nov 24, 2025 •
edited
Loading

Current Issue:
Renovate always pulls the digest from the latest tag, which results in a SHA difference.
However, the version in the values.yaml file is not updated in this scenario, so the digest in the manifests becomes mismatched and stale.

Solution:
Open a PR only when the RepoTags value in values.yaml changes.
Then search for that exact digest in
bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml
instead of using the digest from latest.

check open PRs:
https://github.com/shivakunv/gpu-operator-shiva/pulls

@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch from deb4294 to e789ee7 Compare November 24, 2025 18:37
@shivakunv shivakunv marked this pull request as ready for review November 24, 2025 18:38
@shivakunv shivakunv self-assigned this Nov 24, 2025
@shivakunv
Copy link
Contributor Author

shivakunv commented Nov 24, 2025 •
edited
Loading

PTAL @cdesiniotis @tariq1890

@coveralls
Copy link

coveralls commented Nov 24, 2025 •
edited
Loading

Coverage Status

coverage: 27.711%. remained the same
when pulling e38fef9 on grouptagcommitwithbundle
into 49bc8aa on main.

tariq1890
tariq1890 reviewed Dec 2, 2025
View reviewed changes
@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch 3 times, most recently from a8eb42b to 6f8277b Compare December 3, 2025 05:26
rajathagasthya
rajathagasthya reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

@rajathagasthya rajathagasthya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This largely looks good to me. Just a couple of questions.

shivakunv
shivakunv commented Dec 10, 2025
View reviewed changes
@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch from 6f8277b to f3e6ed9 Compare December 13, 2025 06:48
@shivakunv
Copy link
Contributor Author

shivakunv commented Dec 20, 2025

PTAL @tariq1890
Since @cdesiniotis has already confirmed that this image tagging convention will work, the renovate.json file will not impact our build process.

Regarding this section:

- name: vfio-manager-image
   image: ghcr.io/nvidia/k8s-driver-manager:0d30fa9c

I have only added TODO comments.

@cdesiniotis
Copy link
Contributor

cdesiniotis commented Jan 8, 2026

@shivakunv I took a look at some of the sample PRs raised in your fork, and I noticed that only one line gets updated in the bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml (the CSV file). Note, that for each container image in the CSV file, there are two lines that need to be updated. For example, for dcgm-exporter, both this line and this line need to be updated. Can you confirm that renovate is updating both occurrences? Do you have an example PR that demonstrates this?

@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch 2 times, most recently from 6e19949 to c769a2d Compare January 9, 2026 10:32
@shivakunv
Copy link
Contributor Author

shivakunv commented Jan 9, 2026

@shivakunv I took a look at some of the sample PRs raised in your fork, and I noticed that only one line gets updated in the bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml (the CSV file). Note, that for each container image in the CSV file, there are two lines that need to be updated. For example, for dcgm-exporter, both this line and this line need to be updated. Can you confirm that renovate is updating both occurrences? Do you have an example PR that demonstrates this?

@cdesiniotis Thanks!!
I got carried away by too many changes and accidently removed a required change.
I have corrected it now and updated the code.

Please check my repo PRs opened by renovate:
https://github.com/shivakunv/gpu-operator-shiva/pulls

@cdesiniotis
Copy link
Contributor

cdesiniotis commented Jan 10, 2026

https://github.com/shivakunv/gpu-operator-shiva/pulls

I see two PRs raised today, https://github.com/shivakunv/gpu-operator-shiva/pull/233 and https://github.com/shivakunv/gpu-operator-shiva/pull/232. Both of these PRs only update the helm values, and not the CSV file.

@shivakunv
Copy link
Contributor Author

shivakunv commented Jan 10, 2026

https://github.com/shivakunv/gpu-operator-shiva/pulls

I see two PRs raised today, shivakunv/gpu-operator-shiva#233 and shivakunv/gpu-operator-shiva#232. Both of these PRs only update the helm values, and not the CSV file.

@cdesiniotis
Renovate properties show an older date if we had opened the same package PR earlier.
If you open these PR link (e.g. https://github.com/shivakunv/gpu-operator-shiva/pull/220), you will see that Renovate closes the existing PR and opens a new one.

Please check the snippets below for PR: https://github.com/shivakunv/gpu-operator-shiva/pull/220

image

@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch from c769a2d to eaa6081 Compare February 9, 2026 07:28
rahulait
rahulait reviewed Feb 10, 2026
View reviewed changes
@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch from eaa6081 to 2061238 Compare February 11, 2026 12:03
rahulait
rahulait reviewed Feb 11, 2026
View reviewed changes
rahulait
rahulait reviewed Feb 11, 2026
View reviewed changes
rahulait
rahulait reviewed Feb 11, 2026
View reviewed changes
@rahulait
Copy link
Contributor

rahulait commented Feb 11, 2026

Other than few minor comments, the PR looks good to me.

@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch from 2061238 to 0c22e75 Compare February 12, 2026 11:58
rahulait
rahulait reviewed Feb 12, 2026
View reviewed changes
rahulait
rahulait reviewed Feb 12, 2026
View reviewed changes
@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch from 0c22e75 to b875ade Compare February 12, 2026 16:27
rahulait
rahulait reviewed Feb 12, 2026
View reviewed changes
rahulait
rahulait approved these changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajathagasthya rajathagasthya force-pushed the grouptagcommitwithbundle branch 5 times, most recently from 4c50f01 to a63305b Compare February 18, 2026 22:33
@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch 2 times, most recently from 2587090 to f137ff6 Compare February 19, 2026 05:53
@shivakunv shivakunv mentioned this pull request Feb 19, 2026
Closed
1 task
@rajathagasthya rajathagasthya force-pushed the grouptagcommitwithbundle branch from f137ff6 to 2f55809 Compare February 20, 2026 18:51
cdesiniotis
cdesiniotis reviewed Feb 26, 2026
View reviewed changes
deployments/gpu-operator/values.yaml
repository: nvcr.io/nvidia/cloud-native
image: dcgm
version: 4.5.2-1-ubuntu22.04
version: 4.5.2-1-ubi9
Copy link
Contributor

@cdesiniotis cdesiniotis Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made?

Copy link
Contributor

@cdesiniotis cdesiniotis Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this so that the image in the CSV file and helm values are identical, and therefore, renovate can update them simaltaneously?

Copy link
Contributor

@rajathagasthya rajathagasthya Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

Copy link
Contributor Author

@shivakunv shivakunv Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.
refer : #1935 (comment)

@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch from 2f55809 to 304d31a Compare March 18, 2026 12:11
@shivakunv
fix: update digest lookup to use versioned RepoTags instead of latest
e38fef9 
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
@shivakunv shivakunv force-pushed the grouptagcommitwithbundle branch from 304d31a to e38fef9 Compare March 18, 2026 12:15
@shivakunv
Copy link
Contributor Author

shivakunv commented Mar 18, 2026

opened PRs: https://github.com/shivakunv/gpu-operator/pulls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajathagasthya rajathagasthya rajathagasthya approved these changes

@rahulait rahulait rahulait approved these changes

@cdesiniotis cdesiniotis cdesiniotis left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@elezar elezar Awaiting requested review from elezar

@shivamerla shivamerla Awaiting requested review from shivamerla shivamerla is a code owner

@karthikvetrivel karthikvetrivel Awaiting requested review from karthikvetrivel karthikvetrivel is a code owner

@tariq1890 tariq1890 Awaiting requested review from tariq1890 tariq1890 is a code owner

Assignees

@shivakunv shivakunv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shivakunv @coveralls @cdesiniotis @rahulait @rajathagasthya @tariq1890